1313eb2173
Adds the integration tier — full chain CSV→Parquet→SQL and full
text→embed→vector→search. All 10 cases (4 contract + 6 integration)
end-to-end deterministic; 8s wall total.
Cases added:
01_storage_roundtrip.sh
GOLAKE-010-012. PUT 1KiB → GET sha256-equal → LIST contains key
→ DELETE 200/204 → GET 404. Deterministic key under
proof/<case_id>/ so concurrent runs don't collide.
02_catalog_manifest.sh
GOLAKE-020-022. Fresh register existing=false → manifest read
matches → list contains dataset_id → idempotent re-register
existing=true with stable dataset_id → schema-drift register
409 (the ADR-020 contract). Per-run unique name via
PROOF_RUN_ID so existing=false is meaningful.
03_ingest_csv_to_parquet.sh
GOLAKE-030. workers.csv (5 rows) via /v1/ingest multipart →
parquet object on storaged → catalog manifest with row_count=5.
Verifies content-addressed key shape (datasets/<n>/<fp>.parquet).
04_query_correctness.sh
GOLAKE-040. The 5 SQL assertions from fixtures/expected/queries.json
against the workers fixture: count=5, Chicago=2, max=95,
safety→Barbara, Houston avg=89.5. Iterates the YAML claims, runs
each query, compares response columns to expected values.
06_vector_add_search.sh integration extension
GOLAKE-051. text → /v1/embed (4 docs from fixtures/text/docs.txt)
→ vectord add → search by query embedding. Top-1 ID per query
asserted against fixtures/expected/rankings.json. First run (or
--regenerate-rankings) writes the fixture and emits a skip with
explicit reason; subsequent runs assert against it.
07_vector_persistence_restart.sh
GOLAKE-070. add 4 unit-basis vectors → search → record top-1
distance → SIGTERM vectord → restart with the same --config →
poll /health for 8s → search again → top-1 ID and distance match
bit-identically. Skips with reason if vectord PID can't be found
or post-restart bind times out.
Two harness improvements landed alongside:
run_proof.sh writes a temp lakehouse_proof.toml with
refresh_every="500ms" override and passes --config to all booted
binaries. Production default is 30s; 04_query_correctness needs
queryd to pick up the new view within a tick. Production config
unchanged.
cleanup() now pgreps for any orphan bin/<svc> processes (anchored
to start-of-argv per memory feedback_pkill_scope.md) so a case
that restarts a service mid-run still gets cleaned up.
lib/http.sh adds proof_call(case_id, probe, method, url, args...)
— escape hatch for cases that need raw curl args (multipart -F,
custom headers). Used by 03_ingest for the multipart upload that
conflicts with proof_post's --data + Content-Type defaults.
lib/env.sh exports PROOF_RUN_ID — short unique id derived from the
report directory timestamp. Used by 02 and 07 for fresh-each-run
state isolation.
Two real findings recorded as evidence (no code changes):
- rankings.json fixture pinned: 4 queries → 4 distinct top-1 docs
via nomic-embed-text. A model swap that changes ranking now
fails the harness loudly; --regenerate-rankings is the override.
- vectord persistence kill+restart preserves top-1 distance
bit-identically — the LHV1 single-Put framed format from
G1P round-trips exactly through Save/Load.
Verified end-to-end:
just proof contract — 53 pass (4 cases)
just proof integration — 104 pass (10 cases) · 8s wall
just verify — 9 smokes still green · 33s wall
Phase D (performance baseline) lands next: 10_perf_baseline measures
rows/sec ingest, vectors/sec add, p50/p95 query+search latency, RSS,
CPU. First run writes tests/proof/baseline.json; later runs diff
against it.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
70 lines
2.9 KiB
Bash
Executable File
70 lines
2.9 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# 04_query_correctness.sh — GOLAKE-040.
|
|
# Runs the 5 SQL assertions from fixtures/expected/queries.json against
|
|
# the workers dataset ingested by 03_ingest_csv_to_parquet. Each query
|
|
# is recorded with full evidence; this case is the canonical "does the
|
|
# SQL path return correct results" claim.
|
|
|
|
set -uo pipefail
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
source "${SCRIPT_DIR}/../lib/env.sh"
|
|
source "${SCRIPT_DIR}/../lib/http.sh"
|
|
source "${SCRIPT_DIR}/../lib/assert.sh"
|
|
|
|
CASE_ID="GOLAKE-040"
|
|
CASE_NAME="Query correctness — 5 SQL assertions on workers fixture"
|
|
CASE_TYPE="integration"
|
|
if [ "${1:-}" = "--metadata-only" ]; then return 0 2>/dev/null || exit 0; fi
|
|
|
|
DATASET="proof_workers"
|
|
EXPECTED_FILE="${PROOF_REPO_ROOT}/tests/proof/fixtures/expected/queries.json"
|
|
|
|
# Spec's SQL fixtures use unquoted table name "workers" but ingestd
|
|
# registers under whatever ?name= we passed in 03 — proof_workers.
|
|
# Substitute on the fly so the queries still reference the right view.
|
|
substitute_table() {
|
|
sed "s/FROM workers/FROM ${DATASET}/g; s/from workers/from ${DATASET}/g"
|
|
}
|
|
|
|
# Iterate the 5 queries.
|
|
n=$(jq '.queries | length' "$EXPECTED_FILE")
|
|
for i in $(seq 0 $((n-1))); do
|
|
qid=$(jq -r ".queries[$i].id" "$EXPECTED_FILE")
|
|
qclaim=$(jq -r ".queries[$i].claim" "$EXPECTED_FILE")
|
|
qsql=$(jq -r ".queries[$i].sql" "$EXPECTED_FILE" | substitute_table)
|
|
# Each expected key/value drives one assertion.
|
|
expected_keys=$(jq -r ".queries[$i].expected | keys[]" "$EXPECTED_FILE")
|
|
|
|
# Build a minimal JSON body — escape the SQL via jq.
|
|
body=$(jq -nc --arg sql "$qsql" '{sql:$sql}')
|
|
|
|
proof_post "$CASE_ID" "${qid}_query" \
|
|
"${PROOF_GATEWAY_URL}/v1/sql" \
|
|
"application/json" "$body" >/dev/null
|
|
|
|
qstatus=$(proof_status_of "$CASE_ID" "${qid}_query")
|
|
proof_assert_eq "$CASE_ID" "${qid}: ${qclaim} — query status 200" \
|
|
"200" "$qstatus"
|
|
|
|
# Skip the value assertions if the query failed.
|
|
if [ "$qstatus" != "200" ]; then continue; fi
|
|
|
|
qbody="${PROOF_REPORT_DIR}/raw/http/${CASE_ID}/${qid}_query.body"
|
|
|
|
# queryd response shape: {columns: [{name,type}], rows: [[...]], row_count: N}
|
|
# We compare each expected key against the value at column index for
|
|
# that key in row 0.
|
|
for ek in $expected_keys; do
|
|
expected=$(jq -r ".queries[$i].expected.\"$ek\"" "$EXPECTED_FILE")
|
|
# Find the column index for $ek in the response, then read row[0][idx].
|
|
col_idx=$(jq -r --arg n "$ek" '.columns | map(.name) | index($n)' "$qbody")
|
|
if [ "$col_idx" = "null" ]; then
|
|
_proof_record "$CASE_ID" "${qid}: column ${ek} present in response" \
|
|
fail "${ek}" "<missing>" "column not found in response"
|
|
continue
|
|
fi
|
|
actual=$(jq -r ".rows[0][$col_idx]" "$qbody")
|
|
proof_assert_eq "$CASE_ID" "${qid}: ${qclaim}" "$expected" "$actual"
|
|
done
|
|
done
|