golangLAKEHOUSE/cmd/vectord/main_test.go

package main

import (
	"bytes"
	"net/http"
	"net/http/httptest"
	"strings"
	"testing"

	"github.com/go-chi/chi/v5"

	"git.agentview.dev/profit/golangLAKEHOUSE/internal/vectord"
)

// Closes R-005 for vectord: cmd-level tests for the 6 routes.
// Persistence-disabled mode (h.persist == nil) is the test config —
// keeps tests pure-in-memory; persistence is covered by g1p_smoke +
// proof GOLAKE-070.

func mountedRouter() chi.Router {
	h := &handlers{reg: vectord.NewRegistry()}
	r := chi.NewRouter()
	h.register(r)
	return r
}

func TestRoutesMounted(t *testing.T) {
	r := mountedRouter()
	want := map[string]bool{
		"POST /vectors/index":                 false,
		"GET /vectors/index":                  false,
		"GET /vectors/index/{name}":           false,
		"DELETE /vectors/index/{name}":        false,
		"POST /vectors/index/{name}/add":      false,
		"POST /vectors/index/{name}/search":   false,
	}
	chi.Walk(r, func(method, route string, _ http.Handler, _ ...func(http.Handler) http.Handler) error {
		key := method + " " + route
		if _, ok := want[key]; ok {
			want[key] = true
		}
		return nil
	})
	for sig, found := range want {
		if !found {
			t.Errorf("expected route %q mounted", sig)
		}
	}
}

func TestHandleCreate_HappyPath_201(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	resp, err := http.Post(srv.URL+"/vectors/index", "application/json",
		strings.NewReader(`{"name":"test_idx","dimension":4}`))
	if err != nil {
		t.Fatalf("POST: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusCreated {
		t.Errorf("expected 201 on create, got %d", resp.StatusCode)
	}
}

func TestHandleCreate_MissingDim_400(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	resp, err := http.Post(srv.URL+"/vectors/index", "application/json",
		strings.NewReader(`{"name":"missing_dim"}`))
	if err != nil {
		t.Fatalf("POST: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusBadRequest {
		t.Errorf("expected 400 on missing dim, got %d", resp.StatusCode)
	}
}

func TestHandleCreate_MalformedJSON_400(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	resp, err := http.Post(srv.URL+"/vectors/index", "application/json",
		strings.NewReader("not json"))
	if err != nil {
		t.Fatalf("POST: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusBadRequest {
		t.Errorf("expected 400 on malformed, got %d", resp.StatusCode)
	}
}

func TestHandleCreate_BodyTooLarge(t *testing.T) {
	// 4xx range — see embedd's TestHandleEmbed_BodyTooLarge for the
	// 413-vs-400 unwrap nuance. Contract is "client error, fails loud."
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	big := bytes.Repeat([]byte("x"), maxRequestBytes+(1<<20))
	resp, err := http.Post(srv.URL+"/vectors/index", "application/json", bytes.NewReader(big))
	if err != nil {
		t.Fatalf("POST: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode < 400 || resp.StatusCode >= 500 {
		t.Errorf("expected 4xx on oversize, got %d", resp.StatusCode)
	}
}

func TestHandleGetIndex_NotFound_404(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	resp, err := http.Get(srv.URL + "/vectors/index/nonexistent")
	if err != nil {
		t.Fatalf("GET: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusNotFound {
		t.Errorf("expected 404, got %d", resp.StatusCode)
	}
}

func TestHandleAdd_IndexNotFound_404(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	resp, err := http.Post(srv.URL+"/vectors/index/missing/add", "application/json",
		strings.NewReader(`{"items":[{"id":"v1","vector":[1,2,3,4]}]}`))
	if err != nil {
		t.Fatalf("POST: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusNotFound {
		t.Errorf("expected 404 on add to missing index, got %d", resp.StatusCode)
	}
}

func TestHandleAdd_EmptyItems_400(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	// Create index first.
	http.Post(srv.URL+"/vectors/index", "application/json",
		strings.NewReader(`{"name":"empty_test","dimension":4}`))

	resp, err := http.Post(srv.URL+"/vectors/index/empty_test/add", "application/json",
		strings.NewReader(`{"items":[]}`))
	if err != nil {
		t.Fatalf("POST: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusBadRequest {
		t.Errorf("expected 400 on empty items, got %d", resp.StatusCode)
	}
}

func TestHandleAdd_DimMismatch_400(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	http.Post(srv.URL+"/vectors/index", "application/json",
		strings.NewReader(`{"name":"dim_test","dimension":3}`))

	resp, err := http.Post(srv.URL+"/vectors/index/dim_test/add", "application/json",
		strings.NewReader(`{"items":[{"id":"x","vector":[1,2,3,4]}]}`))
	if err != nil {
		t.Fatalf("POST: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusBadRequest {
		t.Errorf("expected 400 on dim mismatch, got %d", resp.StatusCode)
	}
}

func TestHandleAdd_EmptyID_400(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	http.Post(srv.URL+"/vectors/index", "application/json",
		strings.NewReader(`{"name":"id_test","dimension":4}`))

	resp, err := http.Post(srv.URL+"/vectors/index/id_test/add", "application/json",
		strings.NewReader(`{"items":[{"id":"","vector":[1,2,3,4]}]}`))
	if err != nil {
		t.Fatalf("POST: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusBadRequest {
		t.Errorf("expected 400 on empty id, got %d", resp.StatusCode)
	}
}

func TestHandleSearch_IndexNotFound_404(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	resp, err := http.Post(srv.URL+"/vectors/index/missing/search", "application/json",
		strings.NewReader(`{"vector":[1,2,3,4],"k":5}`))
	if err != nil {
		t.Fatalf("POST: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusNotFound {
		t.Errorf("expected 404 on search of missing index, got %d", resp.StatusCode)
	}
}

func TestHandleDelete_NotFound_404(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	req, _ := http.NewRequest(http.MethodDelete, srv.URL+"/vectors/index/missing", nil)
	resp, err := http.DefaultClient.Do(req)
	if err != nil {
		t.Fatalf("DELETE: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusNotFound {
		t.Errorf("expected 404 deleting missing index, got %d", resp.StatusCode)
	}
}

func TestHandleList_EmptyShape(t *testing.T) {
	r := mountedRouter()
	srv := httptest.NewServer(r)
	defer srv.Close()

	resp, err := http.Get(srv.URL + "/vectors/index")
	if err != nil {
		t.Fatalf("GET: %v", err)
	}
	defer resp.Body.Close()
	if resp.StatusCode != http.StatusOK {
		t.Errorf("expected 200, got %d", resp.StatusCode)
	}
}

func TestSearchK_DefaultsAndMax(t *testing.T) {
	if defaultK <= 0 {
		t.Errorf("defaultK = %d, must be > 0", defaultK)
	}
	if maxK < defaultK {
		t.Errorf("maxK=%d < defaultK=%d", maxK, defaultK)
	}
	// Sanity bounds.
	if maxK > 100_000 {
		t.Errorf("maxK=%d unreasonably large", maxK)
	}
}