From 5df4d4810942930c8ba481bb4a1ebe54f7033ec5 Mon Sep 17 00:00:00 2001 From: root Date: Fri, 24 Apr 2026 06:42:49 -0500 Subject: [PATCH] cleanup: drop two #[allow] attributes that were hiding real dead code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - ingestd/src/service.rs: top-of-file `#[allow(unused_imports)]` was masking genuinely unused `delete` and `patch` routing constructors in an axum import block. Removed the attribute, trimmed the imports to only `get` and `post` (what's actually used). Any future over-import now trips the unused_imports lint immediately instead of being silently allowed. - gateway/src/v1/truth.rs: `truth_router()` was a 4-line stub wrapping a single `/context` route — carried `#[allow(dead_code)]` because v1/mod.rs wires `get(truth::context)` directly onto its own router, bypassing this helper. Zero callers across the workspace. Deleted the function + allow + now-unused Router import. Left a breadcrumb comment pointing to the real wiring. Workspace warnings: 0 (lib + tests). Each #[allow] removed raises the bar on future code entering these modules — the linter now catches the same classes of bugs at PR time. Co-Authored-By: Claude Opus 4.7 (1M context) --- crates/gateway/src/v1/truth.rs | 10 ++++------ crates/ingestd/src/service.rs | 3 +-- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/crates/gateway/src/v1/truth.rs b/crates/gateway/src/v1/truth.rs index b99bdc2..6e900e6 100644 --- a/crates/gateway/src/v1/truth.rs +++ b/crates/gateway/src/v1/truth.rs @@ -1,12 +1,10 @@ -use axum::{routing::get, Router}; use serde::Serialize; use truth::default_truth_store; -#[allow(dead_code)] -pub fn truth_router() -> Router { - Router::new() - .route("/context", get(context)) -} +// Note: truth_router() was a stub wrapper around a single /context route +// that nothing called — v1/mod.rs wires get(truth::context) directly +// onto its own router. Removed 2026-04-24 along with its #[allow(dead_code)] +// attribute; the handler below is the real surface. #[derive(Serialize)] pub struct ContextResponse { diff --git a/crates/ingestd/src/service.rs b/crates/ingestd/src/service.rs index 5bbcb97..bc7f7ed 100644 --- a/crates/ingestd/src/service.rs +++ b/crates/ingestd/src/service.rs @@ -1,10 +1,9 @@ -#[allow(unused_imports)] use axum::{ Json, Router, extract::{Multipart, Path, Query, State}, http::{HeaderMap, StatusCode}, response::IntoResponse, - routing::{delete, get, patch, post}, + routing::{get, post}, }; use bytes::Bytes; use object_store::ObjectStore;