107a68224d
Fields on structs that derive Serialize or Deserialize ARE read — by the macro, on every JSON round-trip — but the static check only looked for explicit `.field` references in the diff. Result: every new response/request struct shipped through `/v1/*` was flagged as "placeholder state without a consumer." PR #11 head 0844206 surfaced 8 such false positives across mode.rs, respond.rs, truth.rs, and profiles/memory.rs — same shape as the existing string-literal exemption for BLOCK_PATTERNS, just at a different syntactic layer. Two helpers added: - extractNewFieldsWithLine: keeps each field's diff-line index so the caller can locate the parent struct. - parentStructHasSerdeDerive: walks back ≤80 lines for a `pub struct` boundary, then ≤8 lines above it for `#[derive(...)]` lines containing Serialize or Deserialize. Stops on closing-brace-at-col-0 to avoid escaping the enclosing scope. Verified on PR #11's actual diff: unread-field warnings dropped from 8 → 0. Synthetic cases confirm the check still fires on plain (non-serde) structs with no in-diff reader, so the genuine-placeholder catch is preserved. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Lakehouse Claim Auditor
A Bun sub-agent that watches open PRs on Gitea, reads the ship-claims in commit messages and PR bodies, and hard-blocks merges when the code doesn't back the claim.
Rationale: when "compiles + one curl works" gets called "phase shipped," placeholder code accumulates. This auditor runs every 90s, fetches each open PR, and subjects it to four checks:
- Static diff — grep/parse looking for placeholder patterns
- Dynamic — runs the never-before-executed hybrid test fixture
- Cloud inference — asks
gpt-oss:120bvia/v1/chatto identify gaps in the diff - KB query — looks up
data/_kb/+ observer for prior failure patterns on similar claims
Verdict is assembled, posted to Gitea as:
- A failing commit status (hard block — branch protection prevents merge)
- A review comment explaining every finding
Run manually
cd /home/profit/lakehouse
bun run auditor/index.ts
Defaults: polls every 90s, stops on auditor.paused file present.
State
data/_auditor/state.json— last-audited head SHA per PRdata/_auditor/verdicts/{pr}-{sha}.json— per-run verdict recorddata/_kb/audit_lessons.jsonl— one row per block/warn finding, path-agnostic signature for dedup. Tailed by kb_query on each audit to surface recurring patterns (2+ distinct PRs with same signature → info, 3-4 → warn, 5+ → block). This is how the auditor learns.data/_kb/scrum_reviews.jsonl— scrum-master per-file reviews. If a file in the current PR has been scrum-reviewed, kb_query surfaces the review as a finding with the accepted model and attempt count.
Where YOU edit
auditor/policy.ts — the verdict assembler. Controls which findings
block vs warn vs inform. All other code is mechanical: fetching,
running checks, posting to Gitea.
Hard-block mechanism
- Commit status is posted as
failurewith contextlakehouse/auditor - If
mainbranch protection requireslakehouse/auditorstatus to pass, Gitea prevents merge - When code is fixed and re-audit passes, status flips to
success, merge unblocks
Enable branch protection (one-time, via Gitea UI or API):
POST /repos/profit/lakehouse/branch_protections{"branch_name": "main", "required_status_checks": {"contexts": ["lakehouse/auditor"]}}