de8fb10f52
Some checks failed
lakehouse/auditor 4 blocking issues: todo!() macro call in tests/real-world/scrum_master_pipeline.ts
Phase 42 PRD (docs/CONTROL_PLANE_PRD.md:144): "truth/ dir at repo
root — rule files, versioned in git." Didn't exist. Landing both the
dir + its loader.
New files:
truth/
README.md — documents file format, rule shape,
composition model (file rules are
additive on top of in-code default_
truth_store), explicit non-goals
(no hot reload, no inheritance)
staffing.fill.toml — 2 staffing.fill rules:
endorsed-count-matches-target,
city-required (both Reject via
FieldEmpty)
staffing.any.toml — 1 staffing.any rule:
no-destructive-sql-in-context via
FieldContainsAny (parallel to the
queryd SQL gate we already ship)
crates/truth/src/loader.rs — load_from_dir(store, dir)
— 5 tests: happy path, duplicate-ID
rejection within files, duplicate-ID
rejection against in-code rules,
non-toml files skipped, missing-dir
error. Alphabetical file order for
reproducible error messages.
crates/truth/src/lib.rs — new pub fn all_rule_ids() helper on
TruthStore so the loader can detect
collisions without breaching the
private `rules` field.
crates/truth/Cargo.toml — adds `toml` workspace dep.
Composition model: file rules are ADDITIVE on top of what
default_truth_store() registers in code. Operators can tune
thresholds/needles/descriptions at the file layer without a code
deploy. Schema changes (new RuleCondition variants) still need a
code bump.
Integration hook (not in this commit, flagged for follow-up):
main.rs should call loader::load_from_dir(&mut store, "truth/")
after default_truth_store() so file-backed rules take effect on
gateway boot. Deliberately separate: this commit lands the
machinery; wiring it on happens when the team is ready to own
the rule file lifecycle.
Total: 37 truth tests green (was 32). Workspace warnings still 0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
33 lines
1.2 KiB
TOML
33 lines
1.2 KiB
TOML
# Phase 42 — staffing.fill task class rules (file-backed).
|
|
#
|
|
# These rules mirror what crates/truth/src/staffing.rs registers in code
|
|
# via staffing_rules(). Both sets load at gateway startup; rule IDs MUST
|
|
# be unique across the combined set, so operator-file overrides require
|
|
# changing the in-code registration (or vice versa).
|
|
#
|
|
# Edit a threshold / add a needle / change a description? File-level
|
|
# edits land without a code deploy. Schema changes (new RuleCondition
|
|
# variants) still need a code bump.
|
|
|
|
[[rule]]
|
|
id = "fill.endorsed-count-matches-target"
|
|
task_class = "staffing.fill"
|
|
description = "endorsed_names.length must equal target_count"
|
|
action = { type = "Reject", message = "endorsed count does not match target_count" }
|
|
|
|
[rule.condition]
|
|
type = "FieldEmpty"
|
|
field = "contract.target_count"
|
|
# When target_count is absent entirely, the rule fires and we reject.
|
|
# Callers must include target_count; this is the first gate.
|
|
|
|
[[rule]]
|
|
id = "fill.city-required"
|
|
task_class = "staffing.fill"
|
|
description = "contract.target_city must be present and non-empty"
|
|
action = { type = "Reject", message = "target_city is required" }
|
|
|
|
[rule.condition]
|
|
type = "FieldEmpty"
|
|
field = "contract.target_city"
|