root dd77632d0e
Some checks failed
lakehouse/auditor 10 blocking issues: cloud: claim not backed — "Verified live (current synthetic data):"
auditor: 2 BLOCK fixes from kimi_architect on a50e9586 audit
Lands 2 of the 3 BLOCKs from the auto-reset commit's audit:

1. static.ts:67-130 — backtick state-machine ordering
   `inMultilineBacktick` was updated AFTER pattern checks ran on a
   line, so any block-pattern hit on a line that opened a backtick
   block was evaluated under stale "outside-backtick" semantics.
   Net effect: false-positive BLOCK findings on hardcoded-string
   patterns sitting inside multi-line template literals (where they
   are legitimately quoted, not executed).
   Fix: compute state-at-line-start BEFORE pattern checks; carry
   state-at-line-end forward for the next iteration. Pattern checks
   now use `stateAtLineStart` consistently.

2. static.ts:223-228 — parentStructHasSerdeDerive bounds check
   The function walked backward from `fieldLineIdx` without
   validating it against `lines.length`. If a malformed diff fed
   in an out-of-range fieldLineIdx, the loop's implicit upper bound
   (`fieldLineIdx - 80`) could still be > 0, leading to undefined-
   slot reads or silently wrong results.
   Fix: defensive bail (`if (fieldLineIdx < 0 || >= lines.length)
   return false`) before the loop runs.

SKIPPED with rationale:

- BLOCK on types.ts:96 (requireSha256 "optional-chaining bypass")
  Investigated: requireString correctly catches null/undefined/object
  via `typeof !== "string"`; the call site at line 96 is just an
  invocation of the function defined at line 81-88. The full code
  paths (null, undefined, object, short string, valid hex) all
  produce correct error/success outcomes. Kimi's rationale was
  truncated at 200 chars; no bypass found in the actual code.
  Treating as a confabulation.

Verification:
  bun build auditor/checks/static.ts                    compiles
  Daemon restart needed to activate; auto-reset cap will fire
  [1/3] on the new SHA.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-27 08:23:03 -05:00
..

Lakehouse Claim Auditor

A Bun sub-agent that watches open PRs on Gitea, reads the ship-claims in commit messages and PR bodies, and hard-blocks merges when the code doesn't back the claim.

Rationale: when "compiles + one curl works" gets called "phase shipped," placeholder code accumulates. This auditor runs every 90s, fetches each open PR, and subjects it to four checks:

  1. Static diff — grep/parse looking for placeholder patterns
  2. Dynamic — runs the never-before-executed hybrid test fixture
  3. Cloud inference — asks gpt-oss:120b via /v1/chat to identify gaps in the diff
  4. KB query — looks up data/_kb/ + observer for prior failure patterns on similar claims

Verdict is assembled, posted to Gitea as:

  • A failing commit status (hard block — branch protection prevents merge)
  • A review comment explaining every finding

Run manually

cd /home/profit/lakehouse
bun run auditor/index.ts

Defaults: polls every 90s, stops on auditor.paused file present.

State

  • data/_auditor/state.json — last-audited head SHA per PR
  • data/_auditor/verdicts/{pr}-{sha}.json — per-run verdict record
  • data/_kb/audit_lessons.jsonl — one row per block/warn finding, path-agnostic signature for dedup. Tailed by kb_query on each audit to surface recurring patterns (2+ distinct PRs with same signature → info, 3-4 → warn, 5+ → block). This is how the auditor learns.
  • data/_kb/scrum_reviews.jsonl — scrum-master per-file reviews. If a file in the current PR has been scrum-reviewed, kb_query surfaces the review as a finding with the accepted model and attempt count.

Where YOU edit

auditor/policy.ts — the verdict assembler. Controls which findings block vs warn vs inform. All other code is mechanical: fetching, running checks, posting to Gitea.

Hard-block mechanism

  1. Commit status is posted as failure with context lakehouse/auditor
  2. If main branch protection requires lakehouse/auditor status to pass, Gitea prevents merge
  3. When code is fixed and re-audit passes, status flips to success, merge unblocks

Enable branch protection (one-time, via Gitea UI or API):

  • POST /repos/profit/lakehouse/branch_protections
  • {"branch_name": "main", "required_status_checks": {"contexts": ["lakehouse/auditor"]}}