local-review-harness/internal/scanner/walk_test.go

package scanner

import (
	"os"
	"path/filepath"
	"testing"
)

// TestWalk_DoesNotSkipBinReportsInTargetRepo locks in scrum fix B5.
// Pre-fix the SkipDirs map basename-matched bin/reports/build/dist
// for ANY repo, silently excluding legitimate source directories on
// real targets (lakehouse Rust has reports/ with markdown). Now
// only universal noise (.git, node_modules, vendor, .venv, .idea,
// etc.) is basename-skipped; harness self-skip is path-scoped.
func TestWalk_DoesNotSkipBinReportsInTargetRepo(t *testing.T) {
	repo := t.TempDir()
	// Plant files under names that USED to be silently skipped.
	for _, p := range []string{
		"bin/script.go",
		"reports/findings.md",
		"build/notes.txt",
		"dist/release.md",
		"target/output.go",
		// Universal-noise dirs SHOULD still skip.
		".git/HEAD",
		"node_modules/foo/index.js",
		"vendor/dep/lib.go",
	} {
		full := filepath.Join(repo, p)
		if err := os.MkdirAll(filepath.Dir(full), 0o755); err != nil {
			t.Fatal(err)
		}
		if err := os.WriteFile(full, []byte("test\n"), 0o644); err != nil {
			t.Fatal(err)
		}
	}

	res, err := Walk(repo, false)
	if err != nil {
		t.Fatalf("Walk: %v", err)
	}

	seen := map[string]bool{}
	for _, f := range res.Files {
		seen[f.Path] = true
	}

	// These MUST appear (B5 fix — used to be silently skipped).
	mustHave := []string{
		"bin/script.go",
		"reports/findings.md",
		"build/notes.txt",
		"dist/release.md",
		"target/output.go",
	}
	for _, p := range mustHave {
		if !seen[p] {
			t.Errorf("expected %q in scan; got %v", p, mapKeys(seen))
		}
	}

	// These MUST be skipped (universal noise).
	mustNotHave := []string{
		".git/HEAD",
		"node_modules/foo/index.js",
		"vendor/dep/lib.go",
	}
	for _, p := range mustNotHave {
		if seen[p] {
			t.Errorf("unexpected %q in scan (universal-noise dir)", p)
		}
	}
}

// TestWalk_SelfSkipsBinReportsInHarnessRepo locks in the path-scoped
// self-skip — when the scanner detects it's being run against the
// harness's own tree (cmd/review-harness AND internal/analyzers
// present), it skips bin/ + reports/ to avoid recursing into its
// own build output and run artifacts.
func TestWalk_SelfSkipsBinReportsInHarnessRepo(t *testing.T) {
	repo := t.TempDir()
	// Plant the marker dirs that signal "this is the harness repo"
	for _, p := range []string{
		"cmd/review-harness/main.go",
		"internal/analyzers/checks.go",
		"bin/review-harness",   // build output — should skip
		"reports/latest/x.json", // runtime — should skip
		"src/real_code.go",     // ordinary source — should appear
	} {
		full := filepath.Join(repo, p)
		_ = os.MkdirAll(filepath.Dir(full), 0o755)
		_ = os.WriteFile(full, []byte("x\n"), 0o644)
	}

	res, err := Walk(repo, false)
	if err != nil {
		t.Fatalf("Walk: %v", err)
	}
	seen := map[string]bool{}
	for _, f := range res.Files {
		seen[f.Path] = true
	}
	for _, want := range []string{
		"cmd/review-harness/main.go",
		"internal/analyzers/checks.go",
		"src/real_code.go",
	} {
		if !seen[want] {
			t.Errorf("expected %q in self-scan; got %v", want, mapKeys(seen))
		}
	}
	// Self-skip should fire on bin/ and reports/.
	if seen["bin/review-harness"] {
		t.Errorf("bin/ should be self-skipped on harness repo")
	}
	if seen["reports/latest/x.json"] {
		t.Errorf("reports/ should be self-skipped on harness repo")
	}
}

func mapKeys(m map[string]bool) []string {
	out := make([]string, 0, len(m))
	for k := range m {
		out = append(out, k)
	}
	return out
}