Claude (review-harness setup) 70d68757f7 docs: SELF_REVIEW snapshot from f3ee472 (Phase A+B MVP)
Per PROMPT.md "Final Deliverable" — capture the harness's review of
its own repo as a tracked artifact. reports/latest/ stays gitignored
for routine runs; this snapshot is the deliverable proof.

Captured: 28 findings, 3 critical (all from tests/fixtures/insecure-repo
planted secrets, intentionally), 16 high (mostly shell-exec patterns
mentioned by name in PROMPT.md and chatd-style scripts), 6 medium,
3 low. Verdict "blocked" because of fixture criticals.

Banner header notes that fixture findings are dismissable; real
codebase secrets land in identical shape — operators dismiss the
fixture path explicitly.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-30 01:02:19 -05:00

local-review-harness

Local-first code review harness. Walks a repository, runs evidence-bearing static checks, generates Scrum-style reports. No cloud dependencies. LLM review is local-Ollama-only (Phase C, not yet shipped).

Per FIRST_COMMAND_FOR_CLAUDE_CODE.md + PROMPT.md — "AI may suggest. Code validates. Reports must show evidence." Findings without grep-able evidence get rejected; the validator phase rejects model claims that cite missing files.

Status

Phase A + Phase B (MVP) shipped. What works today:

  • review-harness repo <path> — Phase 0 intake + Phase 1 static scan
  • review-harness scrum <path> — same pipeline + full Scrum report bundle
  • review-harness model doctor — stub (real Ollama probe in Phase C)
  • 12 static analyzers covering hardcoded paths, shell exec, raw SQL, wildcard CORS, secret patterns, large files, TODO/FIXME, missing tests, committed .env, unsafe file I/O, exposed mutation endpoints, hardcoded private-network IPs

Phases CE pending: real LLM review, validation cross-check, append-only memory, diff/rules subcommands.

Build

Single static binary, no cgo:

go build -o review-harness ./cmd/review-harness

Requires Go 1.22+.

Run

# Full repo review (Phase 0 + Phase 1 + Phase 4)
./review-harness repo /path/to/target/repo

# Same + Scrum bundle (scrum-test.md, risk-register.md, sprint-backlog.md, acceptance-gates.md)
./review-harness scrum /path/to/target/repo

# Model doctor stub
./review-harness model doctor

Reports land in <target>/reports/latest/ by default; override with --output-dir.

Optional config files:

./review-harness scrum /path --review-profile configs/review-profile.example.yaml \
                              --model-profile  configs/model-profile.example.yaml

Self-review

The harness reviews itself as a sanity gate (PROMPT.md "Final Deliverable"):

./review-harness scrum .
cat reports/latest/scrum-test.md

The fixture-planted secrets in tests/fixtures/insecure-repo/ are intentional — they prove the secret-pattern analyzer fires. Operators reviewing the self-report should expect those critical-severity hits and dismiss them as fixture content.

Test fixtures

Three synthetic repos under tests/fixtures/:

Fixture Purpose Expected outcome
clean-repo/ sterile reference 0 confirmed findings
insecure-repo/ every static check fires ≥8 distinct check IDs
degraded-repo/ no git, no manifests repo_intake phase marked degraded

Run them all to validate after a regex change:

for f in clean-repo insecure-repo degraded-repo; do
  ./review-harness scrum "tests/fixtures/$f" > /dev/null
  echo "$f: $(jq '.summary.total' tests/fixtures/$f/reports/latest/static-findings.json) findings"
done

Exit codes

  • 0 — clean run, no degraded phases
  • 64 — usage error
  • 65 — runtime error (config parse fail, target path missing, etc.)
  • 66 — degraded mode (one or more phases skipped or stubbed; reports still produced)

66 is the expected exit code in MVP because the LLM phase is hardcoded degraded until Phase C lands.

Description
Local-first code review harness — evidence-driven, no cloud deps. Sibling to Lakehouse-Go.
Readme 178 KiB
Languages
Go 100%