profit/llm-team-ui
1
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

fix(modes): accept code_review as alias for codereview #5

Closed
profit wants to merge 2 commits from fix/code-review-mode-alias into main
pull from: fix/code-review-mode-alias
merge into: profit:main
Conversation 1 Commits 2 Files Changed 1 +5
profit commented 2026-06-21 03:47:18 +00:00
Owner
Copy Link

Lakehouse observer.ts escalates to /api/run with mode code_review (underscored); canonical mode is codereview, so those calls silently 400. Normalize the alias after reading mode so they validate + dispatch via RUNNERS. One-line behavioral fix; py_compile clean.

Lakehouse observer.ts escalates to /api/run with mode code_review (underscored); canonical mode is codereview, so those calls silently 400. Normalize the alias after reading mode so they validate + dispatch via RUNNERS. One-line behavioral fix; py_compile clean.
profit added 1 commit 2026-06-21 03:47:19 +00:00 
External callers (lakehouse observer.ts) escalate to /api/run with mode
"code_review" (underscored), but the canonical registered mode is "codereview",
so those calls hit the unknown-mode 400 and silently dropped. Normalize the alias
right after reading the mode so it validates and dispatches via RUNNERS.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
profit commented 2026-06-21 04:04:31 +00:00
Author
Owner
Copy Link

✅ Merged into main via 12d7b8c. (Gitea PR-status queue stalled; changes ARE in main.)

✅ Merged into main via 12d7b8c. (Gitea PR-status queue stalled; changes ARE in main.)
profit closed this pull request 2026-06-21 04:04:32 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
profit
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: profit/llm-team-ui#5
No description provided.
Delete Branch "fix/code-review-mode-alias"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?